feat: cli completion

related to #8723 Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
jenkins-x · Nov 9, 2024 · 42e585d · 42e585d
1 parent 61d42d4
commit 42e585d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/cmd/root.go b/pkg/cmd/root.go
@@ -210,7 +210,7 @@ func aliasCommand(rootCmd *cobra.Command, fn func(cmd *cobra.Command, args []str
 		ValidArgsFunction: func(cmd *cobra.Command, completeArgs []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 			cmd, pluginArgs, err := rootCmd.Find(args)
 			if err != nil {
-				return nil, cobra.ShellCompDirectiveError
+				return nil, cobra.ShellCompDirectiveNoFileComp
 			}
 			return plugins.PluginCompletion(cmd, append(pluginArgs, completeArgs...), toComplete)
 		},

diff --git a/pkg/plugins/helpers.go b/pkg/plugins/helpers.go
@@ -328,11 +328,11 @@ func PluginCompletion(cmd *cobra.Command, args []string, toComplete string) ([]s
 
 	pluginDir, err := homedir.DefaultPluginBinDir()
 	if err != nil {
-		return nil, cobra.ShellCompDirectiveError
+		return nil, cobra.ShellCompDirectiveNoFileComp
 	}
 	path, err := Lookup(pluginName, pluginDir)
 	if err != nil {
-		return nil, cobra.ShellCompDirectiveError
+		return nil, cobra.ShellCompDirectiveNoFileComp
 	}
 
 	newArgs := make([]string, len(args)+2)