Update the deploy Dockerfile too

[lemeurherve]

Follow-up of #105

The Dockerfile at

plugin-site-api/deploy/Dockerfile

Line 1 in 4c28d16

FROM jetty:9-alpine

should use the same image as

plugin-site-api/Dockerfile

Line 1 in 4c28d16

FROM jetty:9-jdk8-eclipse-temurin

[sridamul]

Hey, @lemeurherve!
Is there any reason to stick to jdk8?
else
Merging PR #124 will resolve this issue right?

[halkeye]

I would assume this super old project doesn't run in newer java

[halkeye]

@lemeurherve I would argue a ticket with no details whats so ever is not a good first issue

[lemeurherve]

Agree, my bad.

[halkeye]

It happens. I fight that fight a lot at work so could have been more polite sorry.

So the request is copy
https://github.com/jenkins-infra/plugin-site-api/blob/master/Dockerfile#L1
To
https://github.com/jenkins-infra/plugin-site-api/blob/master/deploy/Dockerfile then confirm it works?

[lemeurherve]

Yes exactly, thanks! And no worry I didn't find it not polite ;)

Issue body updated.

[SalmanDeveloperz]

Hey @lemeurherve , @halkeye , I’d like to pick this up!

From what I understand, the task is to update deploy/Dockerfile so it uses the same base image (jetty:9-jdk8-eclipse-temurin) as the main Dockerfile, and then check that the deploy image still builds and runs fine.

Or is there more to it (like java compat checks we should keep in mind)? thx!

[lemeurherve]

That should be sufficient, to be properly tested locally to be sure though.

[lemeurherve]

In retrospect and since we had recent issues around this service, I'd prefer not touching this repo for now, at least not until mid March/April (low bandwidth, and this change is not urgent at all).

I also may take care of this change myself as there are other things I've noticed recently that might need some update too.

[SalmanDeveloperz]

Make sense, thanks for the heads‑up. I’ll leave this one alone for now. if there are other infra issues/repos that could use a hand in the meantime, happy to jump in there.

[lemeurherve]

Thanks, I'll keep that in mind 🙂

BTW, feel free to pass to say hello in one of our incoming infra meetings 😉

https://www.jenkins.io/projects/infrastructure/#meetings