Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jte): Use conventional commit for the title, and create a custom body for this recipe. #606

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix(jte): Use conventional commit for the title, and create a custom body for this recipe. #606

merged 3 commits into from
Jan 10, 2025
+27 −2

Conversation

gounthar
Copy link
Collaborator

@gounthar gounthar commented Jan 10, 2025 •
edited
Loading

When creating this PR, I felt we were missing a section explaining why this change is important. That’s why I propose using the text I came up with for this recipe.

Testing done

mvn clean install

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gounthar gounthar requested a review from jonesbusy as a code owner January 10, 2025 10:06
@jonesbusy jonesbusy merged commit 9e787eb into jenkins-infra:main Jan 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesbusy jonesbusy jonesbusy approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gounthar @jonesbusy