Updates SCM URLs in POM files from git:// to https:// protocol.

[nagu165]

Needs further Review
GitHub has deprecated one of the unauthenticated access protocols (git:// protocol). The pom.xml section that defines the scm for the plugin should refer to the repository with the https:// protocol instead of the git:// protocol

Testing done

This pr still needs some additional review.
What i did till now: Added a recipe in recipes.yml
Created UpdatedScmUrl.java, UpdatedScmUrlVisitor.java, UpdatedScmUrlTest.java

Submitter checklist

• [x ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [ x] Ensure that the pull request title represents the desired changelog entry
• [x ] Please describe what you did
• [x ] Link to relevant issues in GitHub or Jira
• [x ] Link to relevant pull requests, esp. upstream and downstream changes
• [ x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

[krisstern]

Your formatting needs a bit tweaking

[krisstern]

Please also check for any errors or failures in the log say at https://github.com/jenkins-infra/plugin-modernizer-tool/pull/560/checks?check_run_id=35070687985 to debug

[nagu165]

Please also check for any errors or failures in the log say at https://github.com/jenkins-infra/plugin-modernizer-tool/pull/560/checks?check_run_id=35070687985 to debug

Ok sir, Thank you.

[nagu165]

Your formatting needs a bit tweaking

Sorry for not checking them beforehand, I will work on it.

Thank you.

[jonesbusy]

Instead of using lot of level of conditional, we can return directly if the tag is not what we expect.

This would improve readability of the code

if(!"scm".equals(tag.getName()) {
   return tag;
}

[jonesbusy]

Thanks for your PR. Some minor cosmetic, formatting and idioms. Tests also need to be fixed

[nagu165]

Hello sir,
There seems to be some issue in the main branch code since the last time i ran tests.
I was running some tests on my branch(pr branch) and noticed 10 test failures instead of the previously 2, so i tried running tests on the main repo and there were 8 failures introduced

Could you please look into it.

[jonesbusy]

Probably caused by #565 due to a test still hardcoding bom version (that was released some hours ago https://github.com/jenkinsci/bom/releases/tag/3875.v1df09947cde6)

PR need to be rebased when merged on main)

[nagu165]

Hello sir,
Could you please look into the changes to UpdateScmUrlVisitor file.
I've tried many changes but it's always throwing a nullpointerexception.

[jonesbusy]

Can we fix the tests before ?

Caused by: java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:233)
	at org.openrewrite.maven.internal.RawPom.toPom(RawPom.java:408)
	at org.openrewrite.maven.MavenParser.parseInputs(MavenParser.java:78)

Most likely invalid pom

When it's green we can optimize and cleanup the code.

[nagu165]

Can we fix the tests before ?

I thought previously you meant that these test cases would be enough for now

Caused by: java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:233)
	at org.openrewrite.maven.internal.RawPom.toPom(RawPom.java:408)
	at org.openrewrite.maven.MavenParser.parseInputs(MavenParser.java:78)

Most likely invalid pom

When it's green we can optimize and cleanup the code.

Ok sir, working on it.

[jonesbusy]

I thought previously you meant that these test cases would be enough for now

Yes but tests are failing ? What's the point of having failing tests ?

How can we validate the recipe work as expected withtout test ?

[nagu165]

I thought previously you meant that these test cases would be enough for now

Yes but tests are failing ? What's the point of having failing tests ?

How can we validate the recipe work as expected withtout test ?

Then could you please guide me on how to fix the tests sir

Thank you

[jonesbusy]

Then could you please guide me on how to fix the tests sir

I will not do this investigation for you. Try to take a look at the difference with other tests that perform transformation of the pom.xml and that are working.

The only tests that are failing is the 2 that were added

I will put this PR is draft until it's green and ready to be reviewed

Regards,

[nagu165]

Then could you please guide me on how to fix the tests sir

I will not do this investigation for you. Try to take a look at the difference with other tests that perform transformation of the pom.xml and that are working.

The only tests that are failing is the 2 that were added

I will put this PR is draft until it's green and ready to be reviewed

Regards,

Ok sir, Understood
Thank you.

[nagu165]

Why is the build failing here?
They ran successfully for me

[jonesbusy]

Did you read the logs https://github.com/jenkins-infra/plugin-modernizer-tool/pull/560/checks?check_run_id=35114211899 ?

The answer is there.

[nagu165]

Thank you so much sir.