Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete obsolete files on deploy #6677

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Sep 16, 2023

https://blobxfer.readthedocs.io/en/1.0.0/10-cli-usage/ says --delete is what's needed to get rid of obsolete files. I don't have any way to test this.

@hervelemeur
Copy link

Closes jenkins-infra/helpdesk#3360

@lemeurherve
Copy link
Member

We might want to be sure of our backups before merging this in case something goes wrong.

@dduportal
Copy link
Contributor

Thinking about it: if we want to rollback a deletion what would be the options ?

  • backups as @hervelemeur mentioned
  • the azure bucket history (if we can have such feature)
  • Build reproduction (we checkout an old commit an rebuild it to get the files)

@zbynek
Copy link
Contributor Author

zbynek commented Sep 16, 2023

We could also list all files that are in the storage right now (someone with access to Azure would have to help there), compare it with a list of files that are generated by a clean build of this repo and see if anything important would be deleted.

@lemeurherve
Copy link
Member

Preparing a backup of the storage account and a list of its files.

@lemeurherve
Copy link
Member

lemeurherve commented Sep 18, 2023

We could also list all files that are in the storage right now (someone with access to Azure would have to help there), compare it with a list of files that are generated by a clean build of this repo and see if anything important would be deleted.

@zbynek I've posted the corresponding list here, could you take a look at it please?
jenkins-infra/helpdesk#3360 (comment)

@zbynek
Copy link
Contributor Author

zbynek commented Oct 27, 2023

@lemeurherve afaik the conclusion of the helpdesk ticket is that nothing important will disappear. Can we proceed with this?

@lemeurherve
Copy link
Member

@zbynek sorry I wanted to do that this week but been busy on other tasks, I should have posted an update.

I'd like to be sure the backup restore works well before merging this PR, I'll keep you updated.

@lemeurherve
Copy link
Member

@lemeurherve lemeurherve merged commit 5cb4fd4 into jenkins-infra:master Nov 2, 2023
4 checks passed
lemeurherve added a commit that referenced this pull request Nov 2, 2023
lemeurherve added a commit that referenced this pull request Nov 2, 2023
Revert "Delete obsolete files on deploy (#6677)"

This reverts commit 5cb4fd4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs within /doc/book/system-administration are not updating on jenkins.io live
4 participants