-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete obsolete files on deploy #6677
Conversation
Closes jenkins-infra/helpdesk#3360 |
We might want to be sure of our backups before merging this in case something goes wrong. |
Thinking about it: if we want to rollback a deletion what would be the options ?
|
We could also list all files that are in the storage right now (someone with access to Azure would have to help there), compare it with a list of files that are generated by a clean build of this repo and see if anything important would be deleted. |
Preparing a backup of the storage account and a list of its files. |
@zbynek I've posted the corresponding list here, could you take a look at it please? |
@lemeurherve afaik the conclusion of the helpdesk ticket is that nothing important will disappear. Can we proceed with this? |
@zbynek sorry I wanted to do that this week but been busy on other tasks, I should have posted an update. I'd like to be sure the backup restore works well before merging this PR, I'll keep you updated. |
This reverts commit 5cb4fd4.
https://blobxfer.readthedocs.io/en/1.0.0/10-cli-usage/ says
--delete
is what's needed to get rid of obsolete files. I don't have any way to test this.