To get started:
-
Fork a copy of the main repo to your GitHub account.
-
Clone your fork:
git clone git@github.com:YOUR_GITHUB_NAME/police-data-trust.git
-
Add the main repo to your remotes
cd police-data-trust
git remote add upstream https://github.com/codeforboston/police-data-trust.git
git fetch upstream
Now, whenever new code is merged you can pull in changes to your local repository:
git checkout main
git pull upstream main
This method uses Docker to run the complete application stack.
-
Make sure that Docker is installed on your machine.
-
Create a
.env
file in the root of your local project folder, and add your preferred PostgreSQL username and password:
POSTGRES_USER=postgres
POSTGRES_PASSWORD=postgres
POSTGRES_DB=police_data
POSTGRES_HOST=db
- Build and run the project with
docker-compose build; docker-compose up -d; docker-compose logs -f app
This method runs the frontend natively on your computer and does not require a running backend, which can be convenient.
- Make sure that you have
node 16+
and eithernpm 7+
oryarn
installed. - Follow the install instructions in the
frontend
directory.
This style guide is intended to act as a quick reference for the most common scenarios
For this codebase, we are using interfaces instead of type aliases.
-
We are aiming for a loose standard of explicitly typing as little as possible (relying on type inference or third-party library typing files to do the work whenever convenient), but as much as necessary (function params/args are a good example of what the compiler is bad at inferring). Erring on the side of 'stricter than absolutely necessary' definitely works for us!
-
The
any
type should never be utilized here. Prefer union types in the case of values that are initiallynull
(such as values that come from API calls), orunknown
in case of a type being truly impossible to discern ahead of time. -
When typing primitive values declared with
const
, explicitly typing them will be necessary to prevent their type from being implied as the literal value of said primitive, rather than it's corresponding data type.
-
Always use explicit typing in the case of function params and return types.
-
If function parameters don't get modified by the function, strongly consider making them
readonly
to prevent mutation and have clearer code.
- Prefer the
.tsx
file extension when JSX is involved, and.ts
when it isn't.
-
Refer to the React/TypeScript Cheatsheet for examples of common propTypes.
-
In the case of components that accept other React components as props, prefer typing those as
React.ReactNode
.
-
Prefer type inference for
useState
for simple cases. If the hook initializes with a nullish value, strongly consider a union type. -
Since
useEffect
anduseLayoutEffect
don't return values, typing them is not necessary. -
When typing
useRef
, refer to the React/TypeScript cheatsheet for guidance on your specific situation.
-
Type inference should be sufficient in the case of inline event handlers.
-
IDE tooling (such as VSCode autocomplete) will offer helpful suggestions for specific event handler types.
-
The React/TypeScript cheatsheet has a list of specific event types.
Ordering of components —
- Class definitions
- Component / imports
- Event handlers inside class
HTML Props/attributes order:
- id, class, attributes
- Like properties alphabetized (?)
Directory structure:
- Pages: routable containers
- Shared: components being used/planned to be used in multiple places
- Compositions: components that have a single/limited specific context