-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added intro skipper button #1887
base: master
Are you sure you want to change the base?
Conversation
This plugin detects intros in series. This commit adds the button to the UI so the intro can be skipped.
Hi, i just ran across this and gave it a shot. Works Pretty well. I would just like to know why the skip button appears on the left side as opposed to the right side like all other intro skip implementation that i know of like ConfusedPolarBear's Jellyfin-web, Plex or Netflix. |
Just found a bug where when using the minimized player and the skip intro button is visible the middle of the play and pause symbols is not clickable. Clicking the rest of the Player still works fine for pausing or resuming playback. |
For some reason, I remembered netflix's own being on the left. I will adjust that and move it to the right. |
…rlapping with other onscren items.
Thanks for the feedback. The button was overlapping with the other on screen buttons. I have resolved that. |
Would be also great if there is an option to choose between "do nothing", "show skip intro button" or "automatically skip intro" like Emby does But this is already neat |
This can be done from the admin UI (Jellyfin web) in the intro skipper plugin settings. The admin UI has not been ported to Jellyfin-vue yet. |
Works great, thank you! I think what would fit great is if the skip intro button had a hover effect that cancels the hiding of the button like KDE does with notifications. Also it would be nice if we could buffer some video after the intro end so skipping would feel much smoother but this would probably require a second FFMPEG thread or something like that. |
I have created a PR into |
Animate out when hovering skip-intro button
Hmmm, true, but shouldn't this be a user-based option rather than admin (Maybe the plugin itself still doesn't support that way) like Emby does ? |
You should submit an issue to As this is not yet a feature in the plugin |
…o made the fill animation more accurate
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Cloudflare Pages deployment
|
Changed merge title on gibahjoe fork, should fix check failure. |
@gibahjoe I think @ThibaultNocchi already commented this to you, but no PRs are getting merged to master until We also need to discuss how to approach this kind of components that are not part of the "core" server, but based on plugins. |
My bad, I must've missed the comments, |
@ferferga You are right, the frontend should not be implementing non-core plugins. Feel free to close. As an aside, maybe Jellyfin should consider making a skip intro plugin a default plugin. It's a very much needed feature and may prevent users from checking out this vue project. |
We've reached out to the plugin author but they're not interested in upstreaming the plugin (ConfusedPolarBear/intro-skipper#53). Simultaneously someone from our team started work on a core implementation for segment skipping but progress on that has slowed down (jellyfin/jellyfin-meta#30). In summary; we are interested in making intro skipping a core feature of the Jellyfin server so we can support it in all official clients. |
acb6ecf
to
5d6a7c8
Compare
c360429
to
f3260d9
Compare
fe041a3
to
3fbf550
Compare
This PR adds a "skip intro" button which is an implementation of the intro skipper plugin https://github.com/ConfusedPolarBear/intro-skipper
The above plugin is required for this to work.