Certain keybinds not working with mpv 0.40.0

[SergeantBiggs]

Describe the bug
Arch Linux upgraded mpv to 0.40.0. When using that version, certain keybinds do not work anymore. I haven't tested all of them, but it's at least these ones:

• seeking
• quitting (q)

Downgrading fixes the issue.

If needed, just tell me and I can test specific keybinds.

Desktop (please complete the following information):

• OS: Arch Linux

[Shadowghost]

Maybe something needs to be adopted for jaseg/python-mpv@12850b3
Are you using the master version of python-mpv?

[SergeantBiggs]

No, I'm using the version from the Arch Repo, which currently is 1.0.7

[Shadowghost]

That's likely the issue since it does not include the above commit which fixes the compatibility with the current MPV API.

[akagohary]

Having the same issue here, i flagged python-mpv in arch as out of date also referred to everything that was said here maybe it'll be updated to a more recent commit.

[SergeantBiggs]

I don't think the maintainer of the Arch package will go with that. Sounds to me like the proper solution would be that python-mpv releases a new version so that both jellyfin-mpv-shim and the Arch package can both be updated to a version that works with mpv 0.40.0.
@Shadowghost If you want I can create an issue in python-mpv to ask for a new release. I don't know if it will require code changes in jellyfin-mpv-shim itself to work with that new version, but I don't have the python knowledge to build jellyfin-mpv-shim from source with the latest main version of python-mpv

[Shadowghost]

Feel free to do so. Currently the build pipeline uses the master branch, but we can easily switch that back to a specific version.

[akagohary]

I don't think the maintainer of the Arch package will go with that. Sounds to me like the proper solution would be that python-mpv releases a new version so that both jellyfin-mpv-shim and the Arch package can both be updated to a version that works with mpv 0.40.0. @Shadowghost If you want I can create an issue in python-mpv to ask for a new release. I don't know if it will require code changes in jellyfin-mpv-shim itself to work with that new version, but I don't have the python knowledge to build jellyfin-mpv-shim from source with the latest main version of python-mpv

but i don't see any releases on the python-mpv github page, so maybe this package can just be updated to the latest commit, i get what you mean by package maintainers following a release but there is no releases to begin with, although maybe am getting it all wrong :), at the end of the day i just hope we can have a fix cause jellyfin mpv shim is an awesome tool.

[iwalton3]

A possible workaround would be enabling the "external mpv" mode in settings which causes it to use python-mpv-jsonipc which doesn't depend on ABI to work.

[iwalton3]

As for using a newer python-mpv, typically no changes to jellyfin-mpv-shim are needed unless there are breaking changes in the underlying mpv events/commands. An easy way to get tell would be use external mpv because it is higher level and less sensitive to changes.

[akagohary]

A possible workaround would be enabling the "external mpv" mode in settings which causes it to use python-mpv-jsonipc which doesn't depend on ABI to work.

where can i find that please ?

EDIT: its at .conf/jellyfin-mpv-shim/conf.json

switch "mpv_ext": true

and it works flawlessly now :) thank you so much

[akagohary]

Archlinux package maintainer just updated python-mpv with the latest update that includes the api fix and fixed this issue.

@iwalton3 @Shadowghost