feat: add Apple silicon build #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
YangshengLu
reviewed
Apr 28, 2024
| @@ -13,6 +14,9 @@ def main(argv=tuple(sys.argv[1:])): | |||
|
|
|||
| bundle_path = Path(arguments.bundle[0]) | |||
| framework_path = bundle_path / 'Contents' / 'Frameworks' | |||
| rpath_str = '/usr/local/lib' | |||
| if platform.machine() == 'arm64': | |||
| rpath_str = '/opt/homebrew/lib' | |||
There was a problem hiding this comment.
use brew --prefix to get homebrew install prefix ?
There was a problem hiding this comment.
This was initially written for use cases when homebrew is not required(as the old Intel install script does not use homebrew's qt). Probably we can do this for now as the Intel build has to use homebrew's qt as well for now.
iwalton3
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modified the build script to make it build with homebrew's qt5
GitHub's macOS 14 runner is Apple Silicon exclusive, so use that to build the image.
If the artifact is directly downloaded without code signing, the user will have to code sign it. An adhoc sign would be enough:
Fixes #99