Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered set of the various fixes PR #91

Merged
merged 10 commits into from
Dec 11, 2020

Conversation

hawken93
Copy link
Contributor

@hawken93 hawken93 commented Dec 6, 2020

The ones I think are actually useful. Messing around with logging and dev mode idle timeout was too messy for this round.

  • Fix the subtitle check
  • Remove emby references in URLs, lowercase /Videos/ to /videos/ in the directstream case
    • (I wish we could agree on a best practice of using the lowercase variants. The server seems case insensitive.)
  • Add PlayNow command handler, increase verbosity of default handler invocations
  • Start supporting AC-3 and E-AC-3, but disable it in codecSupportHelper because CAF is broken (it seems)
    • Clean up deviceProfile call, make arguments mandatory. Move the ac-3 check to codecSupportHelper.
    • Now everyone gets 2ch aac... Can someone show me 6ch aac working? Does that work on any chromecast?
  • Clean up the max bitrate code because it was transcoding due to exceeded bandwidth when that was false.

@hawken93 hawken93 marked this pull request as draft December 6, 2020 23:19
@hawken93
Copy link
Contributor Author

hawken93 commented Dec 6, 2020

Investigating if this breaks external srt support

@hawken93
Copy link
Contributor Author

hawken93 commented Dec 7, 2020

It did but now it doesn't :)

Instead of the complicated clause, I just check if the URL is defined or not. If it's undefined, that means the server doesn't have an externally loaded subtitle available.

This URL should always be playable because of the profiles that have been set.

If the server adds more things to the list that the server can transcode to vtt, we will be able to get those improvements without code changes.

src/helpers.js Outdated Show resolved Hide resolved
if (subtitleTracks) {
info.tracks = subtitleTracks;
}
info.tracks = subtitleTracks;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My conclusion is that tracks refer to text tracks and that an empty array here doesn't hurt.

The previous if-check always returns true, so this should have no impact.

https://developers.google.com/cast/docs/reference/web_receiver/cast.framework.messages.MediaInformation

MaxStaticBitrate: options.bitrateSetting,
MusicStreamingTranscodingBitrate: Math.min(
options.bitrateSetting,
192000
Copy link
Contributor Author

@hawken93 hawken93 Dec 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1: Is there a good reason for this 192k cap? Should we default to bitrateSetting?
2: Setting MaxStaticBitrate is what I think solves that it always thinks the rate is exceeded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Nah that's probably a good idea to change
  2. I believe MaxStaticBitrate is leftovers from emby for syncing content but I could be wrong

@hawken93 hawken93 marked this pull request as ready for review December 7, 2020 02:42
@YouKnowBlom YouKnowBlom merged commit 7eb681b into jellyfin:master Dec 11, 2020
@gabri94
Copy link

gabri94 commented Jul 6, 2021

Has this been included in a release?

@YouKnowBlom
Copy link
Contributor

It has not yet made it to stable but unstable has it @gabri94

@gabri94
Copy link

gabri94 commented Jul 7, 2021

Unfortunately the unstable branch crashes every time i play a video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants