-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtered set of the various fixes PR #91
Filtered set of the various fixes PR #91
Conversation
Investigating if this breaks external srt support |
6732670
to
4f0fc45
Compare
It did but now it doesn't :) Instead of the complicated clause, I just check if the URL is defined or not. If it's undefined, that means the server doesn't have an externally loaded subtitle available. This URL should always be playable because of the profiles that have been set. If the server adds more things to the list that the server can transcode to vtt, we will be able to get those improvements without code changes. |
… handler more visible in logs
4f0fc45
to
d1af0dc
Compare
if (subtitleTracks) { | ||
info.tracks = subtitleTracks; | ||
} | ||
info.tracks = subtitleTracks; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My conclusion is that tracks
refer to text tracks and that an empty array here doesn't hurt.
The previous if-check always returns true, so this should have no impact.
MaxStaticBitrate: options.bitrateSetting, | ||
MusicStreamingTranscodingBitrate: Math.min( | ||
options.bitrateSetting, | ||
192000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1: Is there a good reason for this 192k cap? Should we default to bitrateSetting?
2: Setting MaxStaticBitrate is what I think solves that it always thinks the rate is exceeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Nah that's probably a good idea to change
- I believe MaxStaticBitrate is leftovers from emby for syncing content but I could be wrong
Has this been included in a release? |
It has not yet made it to stable but unstable has it @gabri94 |
Unfortunately the unstable branch crashes every time i play a video |
The ones I think are actually useful. Messing around with logging and dev mode idle timeout was too messy for this round.