-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make compatible with chromium 83 #86
Conversation
I thought all images were included by |
32e64b7
to
a95ae5d
Compare
I've messed around some more and made it work the way you wanted I think. But please check for yourself too. I also noticed favicon didn't have anything to help it. Keeping in mind that it needs to retain its filename I just copied it over. Without the copy plugin, webpack seemed to ignore it. |
I've added some comments to make it easy to understand my intention with every change |
Looks like it messes up production mode.. |
a95ae5d
to
6ee4b94
Compare
I've reverted back to my copy approach after css-loader introduced more mess than I was able to fix. I also discovered fonts were being left out, so I've fixed that too. Apparently it's not enough to define handlers for the file extensions, they need to be referenced too in a way that webpack understands. css-loader would fix that but it refuses the current index.html way of including them normally. the CSS files can be added as entrypoints, required from app.ts or in index.html they can maybe be referenced like |
If anyone can make it work with css-loader, please open a separate PR and merge that, then I'll make corresponding changes here. :) |
Recommend solving the webpack stuff here: I'll make this PR only about the chromium workaround following merging that one :) |
Converting this to a draft until #88 is ready :p |
6ee4b94
to
cf293a3
Compare
rebased on top of webpack-fix PR, this PR will get much cleaner after that one is merged :) |
1e2a4d0
to
7cda63d
Compare
7cda63d
to
36bd17b
Compare
Updated title and description to match the content of the pr |
Chromium likes to pass event data json encoded, so I made a check to deal with that.
Also 2 BOM removals