Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compatible with chromium 83 #86

Merged
merged 2 commits into from
Dec 6, 2020

Conversation

hawken93
Copy link
Contributor

@hawken93 hawken93 commented Nov 30, 2020

Chromium likes to pass event data json encoded, so I made a check to deal with that.
Also 2 BOM removals

@YouKnowBlom
Copy link
Contributor

I thought all images were included by html-webpack-plugin but I see now that I missed a few, good catch :p. I think we should try to make use of the css-loader plugin as that parses url()s by default

https://webpack.js.org/loaders/css-loader/#url

@hawken93
Copy link
Contributor Author

hawken93 commented Dec 1, 2020

I've messed around some more and made it work the way you wanted I think. But please check for yourself too. I also noticed favicon didn't have anything to help it. Keeping in mind that it needs to retain its filename I just copied it over. Without the copy plugin, webpack seemed to ignore it.

src/css/jellyfin.css Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
@hawken93
Copy link
Contributor Author

hawken93 commented Dec 1, 2020

I've added some comments to make it easy to understand my intention with every change

@hawken93
Copy link
Contributor Author

hawken93 commented Dec 1, 2020

Looks like it messes up production mode..

@hawken93 hawken93 changed the title fix images and make compatible with chromium 83 fix images/fonts and make compatible with chromium 83 Dec 1, 2020
@hawken93
Copy link
Contributor Author

hawken93 commented Dec 1, 2020

I've reverted back to my copy approach after css-loader introduced more mess than I was able to fix. I also discovered fonts were being left out, so I've fixed that too. Apparently it's not enough to define handlers for the file extensions, they need to be referenced too in a way that webpack understands. css-loader would fix that but it refuses the current index.html way of including them normally. the CSS files can be added as entrypoints, required from app.ts or in index.html they can maybe be referenced like <style>css/jellyfin.css</style>. When referenced in index.html they are inlined because reasons.

@hawken93
Copy link
Contributor Author

hawken93 commented Dec 2, 2020

If anyone can make it work with css-loader, please open a separate PR and merge that, then I'll make corresponding changes here. :)

@hawken93
Copy link
Contributor Author

hawken93 commented Dec 2, 2020

Recommend solving the webpack stuff here:
#88

I'll make this PR only about the chromium workaround following merging that one :)

@YouKnowBlom YouKnowBlom marked this pull request as draft December 2, 2020 17:07
@YouKnowBlom
Copy link
Contributor

Converting this to a draft until #88 is ready :p

@hawken93
Copy link
Contributor Author

hawken93 commented Dec 6, 2020

rebased on top of webpack-fix PR, this PR will get much cleaner after that one is merged :)

@hawken93 hawken93 force-pushed the hawken-fixes branch 2 times, most recently from 1e2a4d0 to 7cda63d Compare December 6, 2020 12:38
@hawken93 hawken93 changed the title fix images/fonts and make compatible with chromium 83 make compatible with chromium 83 Dec 6, 2020
@YouKnowBlom YouKnowBlom marked this pull request as ready for review December 6, 2020 14:33
@hawken93
Copy link
Contributor Author

hawken93 commented Dec 6, 2020

Updated title and description to match the content of the pr

@YouKnowBlom YouKnowBlom merged commit 0c071d3 into jellyfin:master Dec 6, 2020
@hawken93 hawken93 deleted the hawken-fixes branch December 6, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants