-
-
Notifications
You must be signed in to change notification settings - Fork 370
Create an Action
ButtonStyle
#1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Well, it looks like Apple is moving toward pill shaped buttons in tvOS 26 😆 |
The only constant is change I suppose lol. I really hope there are some revisions in iOS 26 before the final release. I personally felt like a lot of their demos were really difficult to read with the layered transparency |
#Conflicts: # Swiftfin.xcodeproj/project.pbxproj
Successfully, actually did the re-base! This should be back and buildable. I think this is basically my 'final' version of this with the exception of using the I'm open to suggestions to the gray but I think the rest is good to go! |
I moved the I've tested this as well, I believe we should be able to use this if we want to make the
I wish I could do the same in tvOS but I was finding any buttons you have to build EVERYTHING including the animations for pressing, focus, etc. So I left tvOS mostly alone but I tried to mirror the I am going to stop working on this now so this isn't a moving target to review but this should be done and ready for a second look. |
Summary
Resolves: #1667
Originally Mentioned Here: #1543 (comment)
I wanted to split this out into it's own PR / Discussion for better visibility.
This PR changes the action buttons from their current floating icons to instead use more a square button similar to tvOS. I try to preserve the Icon Color so it doesn't flip when the button goes from selected to unselected. To do this, I am using the same overlay color for the
PlayButton
so it's consistent. Un-selected buttons are.gray
to account for either black or white icon colors.All buttons grow to fill their container, identical to tvOS, except Compact Poster they will always be exact squares similar to the existing layout.
Totally open to suggestions for this! I'm not positive this is what was meant in the original comment but this is where my mind went since this would bring iOS and tvOS in line with similar layouts.
Screenshots
Cinematic
Compact Poster
Generic / Simple Scroll View
Collections
iPadOS - Standard
iPadOS - Collections
Minimum Items vs Maximum Items