adopt new v2 addon format

[aklkv]

• convert to use newer v2 addon format https://github.com/ember-cli/ember-addon-blueprint
• resolve Remove unneeded peer dependency on ember-source #312

[note]: since it's no longer a monorepo, release-it config might need to be adjusted

[jelhan]

Thanks a lot for picking this one up!

It's challenging to review due to the amount of changes to be honest. I noticed some minor point when going through it the first time. I will try finding some time to run it locally as part of final review.

[jelhan]

I tested it out locally. I have a couple of questions:

1. When running pnpm test I see the following build errors:

   vite v7.0.6 building for development...
   <script src="/testem.js"> in "/tests/index.html" can't be bundled without type="module" attribute
   node_modules/.pnpm/ember-tracked-storage-polyfill@1.0.0/node_modules/ember-tracked-storage-polyfill/addon/index.js (1:17): Error when using sourcemap for reporting an error: Can't resolve original location of error.
   node_modules/.pnpm/ember-tracked-storage-polyfill@1.0.0/node_modules/ember-tracked-storage-polyfill/addon/index.js (1:25): Error when using sourcemap for reporting an error: Can't resolve original location of error.
   ✓ 259 modules transformed.
   

   Are those known and could be ignored?

2. The dummy app seems to be dropped. http://localhost:4200 returns a 404 Not Found when running pnpm start. And I don't see a folder for the dummy app in tests/. Is that expected?

[aklkv]

1. first one <script src="/testem.js"> in "/tests/index.html" can't be bundled without type="module" attribute is expected I asked some time ago and all it seems that it's fine
   Second I think it's coming from tracked-built-ins:

devDependencies:
tracked-built-ins 4.0.0
└── ember-tracked-storage-polyfill 1.0.0

I think it's just something inside of that package which is only used for development but works just fine for the purposes that we need I would say it's ok

2. new blueprint doesn't infrastructure out of the box to run dummy app as we used to it can only run tests in the browser as well as in terminal:

• you already figured out that pnpm test will just run in terminal
• to see tests in the browser just run pnpm start this will start the app in dev mode and navigate to http://localhost:4200/tests

There is how ever a way to run manually put together dummy app if we wanted to but I figured there is very little value, here is example but it requires a lot of manual steps to create resolver map https://github.com/ember-a11y/ember-a11y-testing/pull/606/files#diff-3a2d168af53695583f7667831a0ef880c39ac6fad9cc63c2d9ebfb2c4e7fab41R16

Let me know if you still want to bring back the dummy app

[jelhan]

Let me know if you still want to bring back the dummy app

There isn't much value in the dummy app for this repository. I'm fine with dropping it.

http://localhost:4200 not working is likely causing confusion. Especially as the console points users to that URL. Maybe it should redirect to http://localhost:4200/tests? But that's something to change at blueprint level. Not within this addon.

[jelhan]

Thanks a lot!

Just to double check: This is not a breaking change, is it?

[aklkv]

I wouldn't say it's breaking change no, I simply swapped infrastructure and we still have same support level, I still release it as major just to be safe so we do not bumbuzzle people if I broke something be mistake

[aklkv]

I definitely believe management of this addon would become a lot simpler all you have to do is just keep up with deps upgrade and from time to time run ember-cli-update, maybe even create github action

[jelhan]

I wouldn't say it's breaking change no (...) I still release it as major just to be safe so we do not bumbuzzle people if I broke something be mistake

If we broke something, that's a bug we will fix. If we aren't aware of any breaking change, I would go with a minor release.

Major release comes with trade-offs. Especially for this addon as other addons depend on it. Let's avoid that if possible.

[aklkv]

Following up on some warnings that you noticed, it seems we just need to bump vite

embroider-build/embroider#2512 (comment)