Skip to content

only loop once over styles #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

only loop once over styles #140

merged 1 commit into from
Jan 13, 2023

Conversation

@jelhan
Copy link
Owner

@jelhan jelhan commented Jan 13, 2023

Avoid looping twice over the same set for performance reasons. Also trying to improve the readability of the code.

@jelhan
Copy link
Owner Author

jelhan commented Jan 13, 2023

ember-release-no-deprecations scenario is failing due to the @ember/string deprecation added in Ember 4.10. This is addressed by #139.

@jelhan jelhan merged commit 62bd316 into master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jelhan