Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Gemoji 4.0.x as well #94

Closed
wants to merge 2 commits into from

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli requested a review from a team July 5, 2019 15:15
@ashmaroli
Copy link
Member Author

IMO, this shouldn't be merged until gemoji-4.0.0 has been released..

@trueheart78
Copy link

Gemoji v4 has been out for some time. I'd love to see this PR rebased and updated.

@parkr
Copy link
Member

parkr commented Oct 25, 2021

Looks like release candidate 3 is out, but not a finalized version yet. I wonder what they're waiting on. https://rubygems.org/gems/gemoji

@parkr
Copy link
Member

parkr commented Oct 25, 2021

Filed a request: github/gemoji#213

@bewuethr
Copy link

gemoji 4.0.0 has been released today 😃

@ashmaroli
Copy link
Member Author

@bewuethr Thanks for letting us know.
Before proceeding, this repository needs to set up CI via GitHub Actions first.

@parkr
Copy link
Member

parkr commented Nov 16, 2022

Adding Actions CI workflow in #127

@parkr
Copy link
Member

parkr commented Nov 16, 2022

I did a naïve test of gemoji v4 and it passes: #129. We should support v3 and v4 for now so users can downgrade if they don't like v4. Dependabot has already proposed this in #131 so we could extend that with the CI changes.

@parkr
Copy link
Member

parkr commented Nov 16, 2022

This is taken care of in #131. There's some optimization for our CI now (there are 8 actions since the matrix is 2x2x2) but otherwise we're ready to go! We can release a v0.13.0 or a v1.0.0 which allow gemoji v3 and v4.

@parkr parkr closed this Nov 16, 2022
@jekyll jekyll locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants