rubocop: features/step_definitions.rb #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,24 +14,24 @@ | |||
|
|
|||
| # | |||
|
|
|||
| Given %r{^I have a blank site in "(.*)"$} do |path| | |||
| if !File.exist?(path) | |||
| Given(/^I have a blank site in "(.*)"$/) do |path| | |||
There was a problem hiding this comment.
This should still fail, we use %r!! over // or %r{}.
There was a problem hiding this comment.
Hm, actually it failed with %r!!, I guess because we have following in .rubocop.yml
Style/RegexpLiteral:
EnforcedStyle: slashesShould I change it to percent_r ?
There was a problem hiding this comment.
I'll digress to @parkr but we've been moving to %r!! all over the place.
There was a problem hiding this comment.
Only when there is a literal / in the regex
There was a problem hiding this comment.
Which is to say, /test/ is fine, but /test\// is ugly so in that case we use %r!test/! instead.
|
Thanks! Just a few comments. |
|
LGTM |
|
Thank you so much! @jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in features/step_definitions.rb
#4885