reuse provided site instance if available #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mojavelinux
commented
Jul 18, 2016
mojavelinux
commented
- addresses Jekyll core issue Jekyll creates two instances just to boot, build and watch. jekyll#4858
| @@ -4,10 +4,10 @@ module Jekyll | |||
| module Watcher | |||
| extend self | |||
|
|
|||
| def watch(options) | |||
| def watch(options, site = nil) | |||
There was a problem hiding this comment.
Wonderful! Would you mind adding a comment that the site is only populated in Jekyll v3.2 (upcoming) and up? Thanks!
|
LGTM! Just one thought above. |
|
/cc @envygeeks |
- reuse provided site instance (addresses Jekyll core issue #4858) - add API documentation to watch method
mojavelinux
force-pushed
the
jekyll-issue-4858
branch
from
667cd2e to
1c98bcd
Compare
|
API documentation added! |
|
LGTM! Thank you. |
|
LGTM. |
|
@jekyllbot: merge |
jekyllbot
added a commit
that referenced
this pull request
Jul 20, 2016
|
released in v1.5.0! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.