Add support for building the base URL from ENV on Enterprise #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the default mention base URL to be set correctly based on the SSL and GITHUB_HOSTNAME environment variables that are set in a GitHub Enterprise environment, so that https://github.com is not incorrectly used by default.
|
|
||
| it "uses correct mention URLs when SSL and GITHUB_HOSTNAME are set" do | ||
| # Re-render the site, so that ENV is used | ||
| site.render |
There was a problem hiding this comment.
This is done because ENV values are set in this context's before(:each) block, but the site is rendered in the parent before(:each) block, meaning the original render doesn't get the ENV values.
|
Thank you! This LGTM. |
|
LGTM. |
|
@jekyllbot: merge +minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #35 and jekyll/github-metadata#65, and fixes #34.
In a GitHub Enterprise environment, the
SSLandGITHUB_HOSTNAMEenvironment variables are available to the page build process, meaning they can be used to correctly build the base URL for mentions when this plugin is used, instead ofhttps://github.combeing incorrectly used by default.Similar to jekyll/jemoji#45.
@benbalter, @parkr: Could you take a look?