Replaced OpenURI with NET::HTTP and introduced timeout of 3 seconds #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. I just received the Notification that you have merged it. Is the travis build still failing? I haven't had the time to work it out the last week. |
|
Okay, I just saw that you have killed support for Ruby 1.9.3, which is a really great decision! 👍 |
|
Re-released as 1.3.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in the discussion in #7 I replaced
OpenURIwithNET::HTTPand added timeouts of 3 seconds. I will experiment with retries in my local branch and commit that later.