-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for drafts #316
Conversation
What's the point of supporting drafts for a local feed? |
I think this is useful in the deployment process. It's more convenient to create drafts than real posts to test different things.
At present, this behavior is inconsistent. Index is ok, sitemap is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me.
Does not introduce a new option, and does not add much inventory, while matching with Jekyll's current behavior.
That's what I meant. I wanted to use what Jekyll already has. |
@jekyll: merge +minor |
Drafts used to be deliberately excluded (see #94 and #95) and I was surprised to suddenly see my drafts in my feed reader. I exclude drafts from my index page and sitemap as well. I mainly have drafts on my public site so I can share them with specific people for proofreading or to confirm that everything looks fine on mobile. The same workflow is described in #94 and lead to the implementation of the old behavior. Presumably I'm not the only person that relied on the old behavior and other people will update jekyll-feed and then be surprised to find that they are advertising their drafts. |
Version 0.15.1 of jekyll-feed no longer excludes drafts from the feed it generates. I don't want my feed to include drafts so I'm downgrading jekyll-feed. See <jekyll/jekyll-feed#316>. This commit also changes the URLs of my drafts by adding a category (see <https://jekyllrb.com/docs/posts/#categories>). The reason for doing this is that I briefly published a feed generated by jekyll-feed 0.15.1 and that I'd rather have links to drafts from that feed yield 404s.
From now, when you run
jekyll serve --drafts
, your RSS feeds will also contain also drafts posts.The same behavior is in Jekyll Sitemap.