Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump / support typhoeus 1.0 series #231

Closed
decathorpe opened this issue May 31, 2018 · 1 comment · Fixed by #232
Closed

bump / support typhoeus 1.0 series #231

decathorpe opened this issue May 31, 2018 · 1 comment · Fixed by #232
Labels
frozen-due-to-age has-pull-request help wanted

Comments

@decathorpe
Copy link

I'm currently working on getting jekyll to work on fedora again, and one of the things holding me back is the dependency on typhoeus ~> 0.7, whereas fedora already has typhoeus 1.0.2. Would it be possible to support the 1.0 series with the next release of jekyll-feed?
@benbalter
Copy link
Contributor

I think it should be compatible. If anyone would like to try updating the dependency, if tests pass, 👍 (it's only used for tests). One note, I'd suggest making it >= 0.7, < 2.0 to avoid conflict with other (Jekyll) Gems that haven't yet upgraded.

DirtyF added a commit that referenced this issue May 31, 2018
@DirtyF
Support Typhoeus 1.0
5696234 
fix #231
@DirtyF DirtyF mentioned this issue May 31, 2018
Merged
@jekyll jekyll locked and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age has-pull-request help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Typhoeus 1.0 jekyll/jekyll-feed
3 participants
@benbalter @jekyllbot @decathorpe