Fixes broken tests from 4.2 #631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone around to review this? 😬 |
|
@coreycarvalho Thank you for your contribution. Could you try reproducing #630 with |
|
@ashmaroli hey - it looks like this issue is indeed fixed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #630
The issue linked describes the issue.
For the
apiabletest, I opted to change the expected value to what liquid returns. This accounts for potential changes that Jekyll makes to the exact content returned.For the
pagetest, I opted to match against "Test Page", since we can reasonably expect that to be returned regardless of if Jekyll changes the exact values returned.