Skip to content

Remove redundant true passed as prop values #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/Button.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ export default function Button({
icon,
to,
}) {
const btnClass = classnames({
btn: true,
const btnClass = classnames('btn', {
'btn-active': active,
'btn-success': active && (type == 'save' || type == 'create'),
'btn-delete': type == 'delete',
Expand Down
4 changes: 2 additions & 2 deletions src/components/Dropzone.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ export class Dropzone extends Component {
ref="ReactDropzone"
className="dropzone"
activeClassName="dropzone-active"
multiple={true}
disableClick={true}
multiple
disableClick
>
{files.length ? (
<div className="preview-container">
Expand Down
2 changes: 1 addition & 1 deletion src/components/Explorer.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default class Explorer extends Component {
thin
/>
{http_url && (
<Button to={http_url} type="view" icon="eye" active={true} thin />
<Button to={http_url} type="view" icon="eye" active thin />
)}
</div>
</td>
Expand Down
2 changes: 1 addition & 1 deletion src/containers/views/Configuration.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ export class Configuration extends Component {
<Button
onClick={this.toggleView}
type="view-toggle"
active={true}
triggered={this.state.guiView}
active
block
/>
<Button
Expand Down
4 changes: 2 additions & 2 deletions src/containers/views/DataFileEdit.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,17 +200,17 @@ export class DataFileEdit extends Component {
<Button
onClick={this.toggleView}
type="view-toggle"
active={true}
triggered={this.state.guiView}
active
block
/>
)}
<Splitter />
<Button
onClick={() => this.handleClickDelete(filename)}
type="delete"
active={true}
icon="trash"
active
block
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/containers/views/DataFileNew.js
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ export class DataFileNew extends Component {
<Button
onClick={this.toggleView}
type="view-toggle"
active={true}
triggered={this.state.guiView}
active
block
/>
</div>
Expand Down
10 changes: 2 additions & 8 deletions src/containers/views/DocumentEdit.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,20 +172,14 @@ export class DocumentEdit extends Component {
block
/>
{http_url && (
<Button
to={http_url}
type="view"
icon="eye"
active={true}
block
/>
<Button to={http_url} type="view" icon="eye" active block />
)}
<Splitter />
<Button
onClick={this.handleClickDelete}
type="delete"
active={true}
icon="trash"
active
block
/>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/containers/views/Documents.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ export class Documents extends Component {
onClick={() => this.handleClickDelete(name)}
type="delete"
icon="trash"
active={true}
active
thin
/>
{http_url && (
<Button to={http_url} type="view" icon="eye" active={true} thin />
<Button to={http_url} type="view" icon="eye" active thin />
)}
</div>
</td>
Expand Down
10 changes: 2 additions & 8 deletions src/containers/views/DraftEdit.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,19 +149,13 @@ export class DraftEdit extends Component {
icon="save"
block
/>
<Button
to={http_url}
type="view"
icon="eye"
active={true}
block
/>
<Button to={http_url} type="view" icon="eye" active block />
<Splitter />
<Button
onClick={() => this.handleClickDelete(name)}
type="delete"
active={true}
icon="trash"
active
block
/>
</div>
Expand Down
10 changes: 2 additions & 8 deletions src/containers/views/PageEdit.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,19 +151,13 @@ export class PageEdit extends Component {
icon="save"
block
/>
<Button
to={http_url}
type="view"
icon="eye"
active={true}
block
/>
<Button to={http_url} type="view" icon="eye" active block />
<Splitter />
<Button
onClick={() => this.handleClickDelete(name)}
type="delete"
active={true}
icon="trash"
active
block
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/containers/views/StaticFiles.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class StaticFiles extends Component {
onClick={() => this.openDropzone()}
type="upload"
icon="upload"
active={true}
active
/>
</div>
<div className="pull-right">
Expand Down