Deprecate unnecessary constant in GitHubMetadata::Client
#239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Apr 4, 2023
Member
|
IIRC, this was for the Faraday 0.x to 1.0 migration. |
Member
|
@jekyllbot: merge +fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon the realization that
Faraday::ConnectionFailedis valid even in faraday-0.17 and older and that there is no need of testing forFaraday::Error::ConnectionFailed. The latter class is just an alias of the former.Therefore, let us deprecate the
GitHubMetadata::Client::FARADAY_FAILED_CONNECTIONconstant which should have ideally been a private_constant.