Conditionally memoize certain private methods in EditLinkTag #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
mattr-
approved these changes
Mar 23, 2019
DirtyF
approved these changes
Mar 25, 2019
Member
Author
|
@jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
Summary
Jekyll 4.0 caches parsed Liquid Templates. Therefore, when
{% github_edit_link %}is used through a layout or an include, there is just one instance ofJekyll::GitHubMetadata::EditLinkTagin memory.This poses a problem when attributes required for rendering the tag are memoized, resulting in the output of the same result for every page.
The changes proposed here allows compatibility with Jekyll 3.x where memoization improves performance and avoids memoizing when using Jekyll 4.0