Skip to content

Constant accessors for def_delegation #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jekyllbot merged 2 commits into from
Dec 9, 2018
Merged

Constant accessors for def_delegation #141

jekyllbot merged 2 commits into from
Dec 9, 2018

Conversation

@ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Oct 28, 2018

def_delegator and def_delegators can accept existing constants as well.
This means we need not stringify a constant name and then symbolize it..

@ashmaroli ashmaroli requested a review from a team October 28, 2018 07:59
@parkr
Copy link
Member

parkr commented Dec 9, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 2ff9d74 into jekyll:master Dec 9, 2018
jekyllbot added a commit that referenced this pull request Dec 9, 2018
@jekyllbot
Update history to reflect merge of #141 [ci skip]
bc332ee
@ashmaroli ashmaroli deleted the def-delegator-accessors branch December 10, 2018 06:37
@jekyll jekyll locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DirtyF DirtyF DirtyF approved these changes

@parkr parkr parkr approved these changes

@benbalter benbalter benbalter approved these changes

Assignees

No one assigned

Labels

enhancement frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ashmaroli @parkr @DirtyF @benbalter @jekyllbot