-
Notifications
You must be signed in to change notification settings - Fork 156
Fixes for repository detection on Windows #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
552add8
72b977a
d30a531
e744b52
5310d03
1dcd78e
9ceab82
1f99e1d
147d9fc
5341d34
598bc39
f369e51
27cc2d5
939614d
66e5be6
3f3379b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,12 +77,14 @@ | |
| end | ||
|
|
||
| context "when git doesn't exist" do | ||
| before(:each) { @old_path = ENV.delete("PATH").to_s.split(File::PATH_SEPARATOR) } | ||
| after(:each) { ENV["PATH"] = @old_path.join(File::PATH_SEPARATOR) } | ||
| before(:each) do | ||
| @old_path = ENV["PATH"] | ||
| ENV["PATH"] = "" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| end | ||
| after(:each) { ENV["PATH"] = @old_path } | ||
|
|
||
| it "fails with a nice error message" do | ||
| allow(subject).to receive(:git_remote_url).and_call_original | ||
| expect(subject.send(:git_exe_path)).to eql(nil) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we still need to be able to run git? If we're relying on Jekyll::Utils::Exec, then we'll definitely need to make sure that the exe can be found, right?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Relying on
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, so we can remove
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep. In fact, this PR has already removed it.. |
||
| expect(subject.send(:git_remote_url)).to be_empty | ||
| end | ||
| end | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.