Histogram upgrade #361
Merged
Histogram upgrade #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prune older than patch
Cadair
reviewed
May 18, 2021
Comment on lines
+15
to
+16
| find "${IMAGE_OUTPUT}/" -maxdepth 1 -type f -name "${img_path}*.jpg" exec rm -f {}; | ||
| find "${IMAGE_OUTPUT}/thumb/" -maxdepth 1 -type f -name "${img_path}*.jpg" exec rm -f {}; |
There was a problem hiding this comment.
I just merged this in the other PR, so this probably needs an update.
dom-robinson
approved these changes
May 29, 2021
There was a problem hiding this comment.
From my point of view this checks out. @Cadair do you want to do the merge honours :)
|
The problem with this merge is the browser still looks for the jpg file.
…On Sat, May 29, 2021 at 2:06 AM Dom Robinson ***@***.***> wrote:
***@***.**** approved this pull request.
From my point of view this checks out. @Cadair <https://github.com/Cadair>
do you want to do the merge honours :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#361 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH3WJEALDCX5PHVBMFZDBRTTQCVC5ANCNFSM42VVLYZA>
.
|
|
@colinluthier @Cadair are we 'go' with this? Want me to merge it in now? |
|
I have not had time to look for the browser bug. It works on my production
system but I can’t merge from it and the changes code was added by Justin.
I have not found it.
…On Tue, Aug 17, 2021 at 9:26 AM Dom Robinson ***@***.***> wrote:
@colinluthier <https://github.com/colinluthier> @Cadair
<https://github.com/Cadair> are we 'go' with this? Want me to merge it in
now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#361 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH3WJEHY676A4BBE6UWBQGLT5KESZANCNFSM42VVLYZA>
.
|
|
I think this PR needs master merging in? |
|
This looks like everyone was approving it but not actually merging it so i thought I’d ‘just do it’ :) Lets hope its not breaking :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jekhokie I didn't make the new file executable but I think the rest is in place.