Skip to content

Error queue excluded from list queues prefix in ListQueues check #61

Open
#68
Open
Error queue excluded from list queues prefix in ListQueues check#61
#68

Description

@andrewatwood
andrewatwood
opened on Jul 15, 2023

Say I have two existing queues: a queue process-queue and an error queue error-queue.

My error queue is never flagged as existing because the ListQueues operation is prefixed to the main queue name:

python-sqs-listener/sqs_listener/__init__.py

Lines 85 to 94 in 03400ca

queues = sqs.list_queues(QueueNamePrefix=self._queue_name)
main_queue_exists = False
error_queue_exists = False
if 'QueueUrls' in queues:
for q in queues['QueueUrls']:
qname = q.split('/')[-1]
if qname == self._queue_name:
main_queue_exists = True
if self._error_queue_name and qname == self._error_queue_name:
error_queue_exists = True

The listener attempts to create the error queue since it wasn't found, and gets a QueueAlreadyExists error immediately.

If I specify the error queue as process-queue-error and it already exists, I don't get any errors, because it comes back in the ListQueues call that uses the prefix.

A couple solutions to this but it's a pretty big issue for anyone using pre-created queues.

Activity

  1. jegesh commented on Aug 8, 2023

    @jegesh
    jegesh
    on Aug 8, 2023
    Owner

    Yeah the code is pretty naive about these things. Feel free to submit a PR with your implementation to solve your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions