Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ale_aos8_show_transceivers #23

Merged

Conversation

BennyE
Copy link
Contributor

@BennyE BennyE commented Apr 1, 2022

It appears that the transceivers report whitespaces as part of their serial/part number, thus I kept it for the yml as they report it.

Output of tox:

_______________________________________________________________________________ summary ________________________________________________________________________________
  black: commands succeeded
  flake8: commands succeeded
  pylama: commands succeeded
  yamllint: commands succeeded
  congratulations :)

Output of pytest:

(.venv) benny@Bennys-MacBook-Pro textfsm-aos % pytest
========================================================================= test session starts ==========================================================================
platform darwin -- Python 3.8.9, pytest-7.0.1, pluggy-1.0.0
rootdir: /Users/benny/Python/textfsm-aos
collected 37 items                                                                                                                                                     

tests/test_parsed_data.py .....................................                                                                                                  [100%]

========================================================================== 37 passed in 0.45s ==========================================================================

Copy link
Owner

@jefvantongerloo jefvantongerloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added two parameters:

    • alu_model_name
    • alu_model_number
  • Trimmed trailing whitespaces

@jefvantongerloo
Copy link
Owner

Merged, thanks for PR!

@jefvantongerloo jefvantongerloo merged commit c585b6a into jefvantongerloo:main Apr 4, 2022
@BennyE BennyE deleted the ale_aos8_show_transceivers branch April 5, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants