Skip to content

Commit

Permalink
Workaround thread safety issue by limiting worker count
Browse files Browse the repository at this point in the history
The original intent of this code was to workaround a thread safety
issue. However, according to the `poetry` maintainer, the more "future
proof" workaround is [to limit the worker count rather than disable the
new
installer](python-poetry/poetry#3010 (comment)).

The underlying root issue is supposedly resolved in [newer versions of
`poetry`](python-poetry/poetry#3010 (comment)),
which I will do in a follow-on PR. But wanted to first update the
workaround so that if we need to revert the upgrade we still have the
better workaround in place.
  • Loading branch information
jeffwidman committed Aug 8, 2022
1 parent ef77321 commit b6f3f20
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/helpers/build
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ PYENV_VERSION=3.10.5 pyenv exec pip install -r "requirements.txt"
# Workaround of https://github.com/python-poetry/poetry/issues/3010
# By default poetry config file is stored under ~/.config/pypoetry
# and is not bound to any specific Python version
PYENV_VERSION=3.10.5 pyenv exec poetry config experimental.new-installer false
PYENV_VERSION=3.10.5 pyenv exec poetry config installer.max-workers 1

0 comments on commit b6f3f20

Please sign in to comment.