Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"limit" param for collections / ability to override top level json element name #83

Merged
merged 3 commits into from
Jun 3, 2014

Conversation

scottwainstock
Copy link

You've created an amazing tool here, thank you for that. This pull request adds:

  • The ability to pass a "limit" param to collections and have the return results be limited to N
  • The ability to define a top level json element name in a model class (default is "resources")

I've got a project that has worked perfectly with "out of the box" sandman with the exception of these two features. Limit seems like a no-brainer to me. The top level json element feature was to give sandman the flexibility to be consistent with the payload formats that other APIs use.

If I'm missing any tests or anything else you'd like to see, let me know, I'd be happy to follow up on your feedback!

Thanks again for this cool tool,
Scott

@coveralls
Copy link

Coverage Status

Coverage increased (+0.17%) when pulling db8fc6b on scottwainstock:develop into 5c4b707 on jeffknupp:develop.

jeffknupp added a commit that referenced this pull request Jun 3, 2014
"limit" param for collections / ability to override top level json element name
@jeffknupp jeffknupp merged commit 8d28744 into jeffknupp:develop Jun 3, 2014
@jeffknupp
Copy link
Owner

Thanks for some great additions! Merged happily

1 similar comment
@jeffknupp
Copy link
Owner

Thanks for some great additions! Merged happily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants