Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container): createScope return defaults to original container #182

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

moltar
Copy link

@moltar moltar commented Apr 13, 2020

Closes #178

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c0c7160 on moltar:master into 7625dd9 on jeffijoe:master.

@jeffijoe
Copy link
Owner

Looks good! Can I ask you to do a few small things in this PR as well?

  • Remove yarn.lock, run npm install to switch to NPM. Yarn seems to have gone off the deep end.
  • npm i -D rimraf to fix contributing docs errors #179
  • Run npx npm-check --skip-unused -u to upgrade all packages to latest, run lint and cover (I expect prettier@2 will format all files, that's fine)

@moltar
Copy link
Author

moltar commented Apr 13, 2020

Seems like outside the scope of a PR.

Maybe we should do a separate PR?

@moltar
Copy link
Author

moltar commented Apr 13, 2020

And for updates, wouldn't it better to setup @renovatebot?

@jeffijoe
Copy link
Owner

I'm fine with it being the same PR, the update will go out as a single release anyway, I am just trying to cut down on needless bureaucratic work.

I haven't set up automated releases for Awilix because I've had some issues with it in the past, and I also don't want to release a new version every 12 hours because of package updates 🤣

However anytime there are actual changes that need to be released, I update the deps before doing so.

@jeffijoe jeffijoe merged commit aac4517 into jeffijoe:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createScope should return container type by default
3 participants