Microcenter in stock false positive

[solonrice]

Expected Behavior

When out of stock or 0 stock, should not be considered in stock and no alert triggered.

Current Behavior

When the page says "0 NEW IN STOCK", the app considers this to be "in stock" and triggers an alert.

Steps to Reproduce

Setup "microcenter" for a store, and look for 3080 series. It looks like Microcenter might sometimes show "0 NEW IN STOCK" or "OUT OF STOCK" interchangeably.

Environment

• OS: Windows

Logs

[9:45:20 AM] info :: 🚀🚨 [microcenter] [zotac (3080)] trinity :: IN STOCK 🚨🚀
https://www.microcenter.com/product/628607/zotac-geforce-rtx-3080-trinity-overclocked-triple-fan-10gb-gddr6x-pcie-40-graphics-card/?storeid=055

[dhoeppne]

+1 on this for the 3090, seeing false positives like crazy.

[riggga]

This is happening for me too, I am just going to remove microcenter for now. @jef could you check this out? Thank you!

[solonrice]

Microcenter must have changed something last night.

I am very new to this codebase, but testing this right now. Seems to be working so far:

index fc0dd2b..3d72f3e 100644
--- a/src/store/model/microcenter.ts
+++ b/src/store/model/microcenter.ts
@@ -281,6 +281,10 @@ export const MicroCenter: Store = {
       container: '#pnlInventory',
       text: ['in stock'],
     },
+    outOfStock: {
+      container: '#pnlInventory',
+      text: ['0 new in stock']
+    },
     maxPrice: {
       container: 'span[id="pricing"]',
     },

EDIT: the biggest question in my mind is: does this actually indicate a possible in-stock scenario, but at the store only?

[vulpicastor]

Should the out of stock be

text: ['sold out', '0 new in stock'],

instead, to incorporate the still existing old wording?