Fix empty password makes the sk unusable - #31
Closed
Legend-Master wants to merge 3 commits into
Closed
Conversation
Legend-Master
commented
Mar 3, 2026
| let KeyPair { pk, sk } = KeyPair::generate_encrypted_keypair(password.clone()).unwrap(); | ||
| _ = pk; | ||
| let sk_box = sk.to_box(None).unwrap(); | ||
| assert!(sk_box.clone().into_secret_key(password).is_err()); |
Author
There was a problem hiding this comment.
Not entirely sure if this makes sense, the same password used in generate_encrypted_keypair can't be used to decrypt it with into_secret_key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix passing in an empty password to
generate_encrypted_keypair(or from its prompts) makes the generated secret key not useable (can't be decoded through bothinto_secret_keyandinto_unencrypted_secret_key)Reference tauri-apps/tauri#14829