add hyperlink formatter #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4973056443
💛 - Coveralls |
|
Kudos, SonarCloud Quality Gate passed!
|
jedib0t
reviewed
May 23, 2023
Comment on lines
+9
to
+11
| if text == "" { | ||
| return url | ||
| } |
There was a problem hiding this comment.
It may be better to default the text to url if no text was provided?
Also, rename text to alias?
jedib0t
reviewed
May 23, 2023
| assert.Equal(t, "Ghost", Hyperlink("", "Ghost")) | ||
| assert.Equal(t, "https://example.com", Hyperlink("https://example.com", "")) | ||
| assert.Equal(t, "\x1b]8;;https://example.com\x1b\\Ghost\x1b]8;;\x1b\\", Hyperlink("https://example.com", "Ghost")) | ||
| } |
There was a problem hiding this comment.
Can you add an Example function for godoc? You can take a look at some of the other test files in this package to see what I'm talking about.
|
@sanyatuning I'm not sure if you got notifications of my comments above. Pinging again just in case. |
|
Due to lack of response, I've merged the PR. Will work on the comments listed above myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes