Skip to content

Commit

Permalink
Revert "Fix possible endless wait in stop() after AUTH_FAILED error (p…
Browse files Browse the repository at this point in the history
…ython-zk#688)"

This reverts commit 5225b3e.
  • Loading branch information
jeblair committed Feb 22, 2024
1 parent b00d88f commit 95e42c9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion kazoo/protocol/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ def _connect_attempt(self, host, hostip, port, retry):
self.ping_outstanding.clear()
last_send = time.monotonic()
with self._socket_error_handling():
while not self.client._stopped.is_set():
while True:
# Watch for something to read or send
jitter_time = random.randint(1, 40) / 100.0
deadline = last_send + read_timeout / 2.0 - jitter_time
Expand Down
2 changes: 0 additions & 2 deletions kazoo/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,6 @@ def test_async_auth_failure(self):
with pytest.raises(AuthFailedError):
client.add_auth("unknown-scheme", digest_auth)

client.stop()

def test_add_auth_on_reconnect(self):
client = self._get_client()
client.start()
Expand Down

0 comments on commit 95e42c9

Please sign in to comment.