Skip to content

Commit

Permalink
Delete LoginErrorFactory
Browse files Browse the repository at this point in the history
Summary: This type is now unnecessary

Reviewed By: joesus

Differential Revision: D36927175

fbshipit-source-id: 25fa3077f64a51b69b74a0a2a26b2f0183023219
  • Loading branch information
samodom authored and facebook-github-bot committed Jun 6, 2022
1 parent 5807f05 commit 25eef8b
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 253 deletions.
3 changes: 1 addition & 2 deletions FBSDKLoginKit/FBSDKLoginKit/FBSDKLoginManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#import <FBSDKLoginKit/FBSDKLoginKit-Swift.h>

#import "FBSDKCodeVerifier.h"
#import "FBSDKLoginErrorFactory.h"

static int const FBClientStateChallengeLength = 20;
static NSString *const FBSDKExpectedChallengeKey = @"expected_login_challenge";
Expand Down Expand Up @@ -296,7 +295,7 @@ - (nullable NSError *)_verifyChallengeWithCompletionParameters:(FBSDKLoginComple
NSString *challengeReceived = parameters.challenge;
NSString *challengeExpected = [[self loadExpectedChallenge] stringByReplacingOccurrencesOfString:@"+" withString:@" "];
if (![challengeExpected isEqualToString:challengeReceived]) {
return [FBSDKLoginErrorFactory fbErrorForFailedLoginWithCode:FBSDKLoginErrorBadChallengeString];
return [NSError errorWithDomain:FBSDKLoginErrorDomain code:FBSDKLoginErrorBadChallengeString userInfo:nil];
} else {
return nil;
}
Expand Down
26 changes: 0 additions & 26 deletions FBSDKLoginKit/FBSDKLoginKit/Internal/FBSDKLoginErrorFactory.h

This file was deleted.

114 changes: 0 additions & 114 deletions FBSDKLoginKit/FBSDKLoginKit/Internal/FBSDKLoginErrorFactory.m

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#import "FBSDKAuthenticationTokenCreating.h"
#import "FBSDKCodeVerifier.h"
#import "FBSDKDevicePolling.h"
#import "FBSDKLoginErrorFactory.h"
#import "FBSDKLoginProviding.h"

// +Testing.h files
Expand Down
110 changes: 0 additions & 110 deletions FBSDKLoginKit/FBSDKLoginKitTests/LoginErrorFactoryTests.swift

This file was deleted.

0 comments on commit 25eef8b

Please sign in to comment.