Repository navigation
fix(deps): bump self_update to 1.3 to clear quick-xml advisories - #12714
Conversation
Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0194 Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0195 Severity: high (CVSS 7.5, availability DoS) self_update 0.44 pulled quick-xml 0.38.4 (quadratic attribute-name checking + unbounded namespace allocation). self_update 1.x moves quick-xml behind the optional s3 feature, which mise does not enable, so the vulnerable crate drops out of the default dependency graph. Also migrate the self-update call sites to the 1.0 API (VersionStatus, release_tag, is_updated, Releases::latest) and drop the deny.toml ignores that existed only while upstream was stuck below quick-xml 0.41.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe self-update dependency was upgraded to version 1. The implementation now uses ChangesSelf-update migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to The update removes the vulnerable dependency and preserves the existing repository, archive, and signature-verification controls. It is mergeable with owner awareness that interruption, cleanup, and atomic replacement behavior in the upgraded self-update dependency should be confirmed. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR upgrades
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The dependency graph removes the vulnerable quick-xml version, the migrated feature combinations are covered by repository build configurations, and the self-update API changes preserve the existing release-tag, reporting, and signature-verification flow. Important Files Changed
Reviews (1): Last reviewed commit: "fix(deps): bump self_update to 1.3 to cl..." | Re-trigger Greptile |
Automated dependency bump to address disclosed CVEs in a transitive dependency of
self_update.self_update0.44.0→1.3.0(drops transitivequick-xml0.38.4; remainingquick-xmlusage is only0.41.0viaplist/rattler_menuinst)Why this works
self_update1.x gatesquick-xmlbehind the optionals3feature. mise only uses the GitHub backend, so enablinggithub+ the existing archive/signature features leaves the vulnerable0.38line out of the default graph. The Julydeny.tomlignores (#10717) can therefore be removed.Verification
cargo tree -i quick-xml@0.38.4(fails: package not present) /cargo tree -i quick-xml@0.41.0/cargo checkself_update 0.44.0→quick-xml 0.38.4(RUSTSEC-2026-0194/0195)quick-xml 0.38.4; onlyquick-xml 0.41.0cargo checkclean on linux amd64Detected by osv-scanner. Call-site edits follow the upstream 0.x → 1.0 migration guide (
VersionStatus,release_tag,is_updated,Releases::latest).Summary by CodeRabbit