Skip to content

fix(doggo): use github backend for v1.2.0 asset naming#10601

Closed
jhult wants to merge 1 commit into
jdx:mainfrom
jhult:fix/doggo
Closed

fix(doggo): use github backend for v1.2.0 asset naming#10601
jhult wants to merge 1 commit into
jdx:mainfrom
jhult:fix/doggo

Conversation

@jhult

@jhult jhult commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Doggo v1.2.0 changed its release asset naming from versioned (doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless (doggo-{{os}}-{{arch}}.tar.gz) with lowercase OS names and aarch64/i386 arch naming.

The vendored aqua registry doesn't yet handle this. The upstream fix has been submitted to aquaproj/aqua-registry (PR #55890) and will flow in on the next vendored registry sync.

In the meantime, this switches to the github: backend with an explicit asset_pattern so doggo v1.2.0+ can be installed immediately. Once the upstream fix is vendored, this can be reverted back to aqua:mr-karan/doggo.

This PR was generated with the assistance of an AI coding agent.

Summary by CodeRabbit

  • Chores
    • Expanded package release targeting to better match GitHub build assets across operating systems and CPU architectures.
    • Improved archive selection so downloads use the appropriate file format for Windows and other platforms.

Doggo v1.2.0 switched from versioned assets (doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless assets (doggo-{{os}}-{{arch}}.tar.gz). The vendored aqua registry entry doesn't yet handle this change — the upstream fix is at aquaproj/aqua-registry#55890 and will flow in on the next vendored registry sync.

In the meantime, switch to the github: backend with an explicit asset_pattern that matches the new naming convention. This allows installing doggo v1.2.0+ immediately. Once the upstream aqua-registry fix is vendored, this can be reverted back to the aqua: backend.
EOF
)
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

registry/doggo.toml is updated to replace the single backends string with an array containing a GitHub backend pointing to mr-karan/doggo. The asset_pattern is expanded to conditionally use .zip on Windows or .tar.gz elsewhere, and maps x86_64, arm64, and i386 to doggo's release archive naming.

Changes

doggo registry backend update

Layer / File(s) Summary
doggo backend array and asset pattern
registry/doggo.toml
Converts backends from a single string to a GitHub-sourced array; the asset_pattern now conditionally selects .zip on Windows or .tar.gz otherwise, and maps x86_64/arm64/i386 to doggo release naming.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit sniffed the TOML trail,
And found the backend short and frail.
Now zip for Windows, tar for the rest,
With arm64 and x86 addressed —
🐇 Doggo fetches, passing every test!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: switching Doggo to a GitHub backend to handle the v1.2.0 asset naming change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR works around a breaking asset-naming change introduced in doggo v1.2.0, where release archives switched from versioned (doggo_{{version}}_Linux_x86_64.tar.gz) to versionless, lowercase names (doggo-linux-x86_64.tar.gz). Because the vendored aqua registry hasn't been updated yet, the entry is temporarily switched to the github: backend with an explicit asset_pattern.

  • The Jinja2-style asset_pattern correctly maps macos→darwin, leaves linux as-is, and appends .zip for Windows and .tar.gz for all other platforms, consistent with how similar tools (daytona, porter) are configured in this registry.
  • No explicit bin= override is needed for Windows because the .zip asset is an archive—mise extracts it and auto-discovers the doggo.exe binary, unlike the daytona/porter entries where the Windows asset is a raw .exe file that requires the bin hint.

Confidence Score: 4/5

Safe to merge as a temporary workaround; the asset pattern is consistent with established conventions in the registry and should resolve v1.2.0 install failures immediately.

The one-line pattern change is well-formed and mirrors existing entries. The only unverified assumption is whether doggo actually ships a Windows .zip asset in v1.2.0 (versus no Windows build at all), but Windows support is evidenced by Scoop/Winget packaging, making this low risk.

registry/doggo.toml — worth verifying that Windows .zip assets exist in the v1.2.0 release before the PR is merged, and that a revert/follow-up ticket is tracked for when the aqua registry sync lands.

Important Files Changed

Filename Overview
registry/doggo.toml Switches backend from aqua:mr-karan/doggo to github:mr-karan/doggo with an explicit asset_pattern to accommodate v1.2.0's new versionless asset naming; the OS/arch mappings look correct for Linux and macOS but Windows .zip support is unverified

Reviews (1): Last reviewed commit: "fix(doggo): use github backend for v1.2...." | Re-trigger Greptile

@jhult

jhult commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Closing as it looks like #10594 included aquaproj/aqua-registry#55890.

@jhult jhult closed this Jun 29, 2026
@jhult jhult deleted the fix/doggo branch June 29, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant