fix(doggo): use github backend for v1.2.0 asset naming#10601
Conversation
Doggo v1.2.0 switched from versioned assets (doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless assets (doggo-{{os}}-{{arch}}.tar.gz). The vendored aqua registry entry doesn't yet handle this change — the upstream fix is at aquaproj/aqua-registry#55890 and will flow in on the next vendored registry sync.
In the meantime, switch to the github: backend with an explicit asset_pattern that matches the new naming convention. This allows installing doggo v1.2.0+ immediately. Once the upstream aqua-registry fix is vendored, this can be reverted back to the aqua: backend.
EOF
)
📝 WalkthroughWalkthrough
Changesdoggo registry backend update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR works around a breaking asset-naming change introduced in doggo v1.2.0, where release archives switched from versioned (
Confidence Score: 4/5Safe to merge as a temporary workaround; the asset pattern is consistent with established conventions in the registry and should resolve v1.2.0 install failures immediately. The one-line pattern change is well-formed and mirrors existing entries. The only unverified assumption is whether doggo actually ships a Windows registry/doggo.toml — worth verifying that Windows Important Files Changed
Reviews (1): Last reviewed commit: "fix(doggo): use github backend for v1.2...." | Re-trigger Greptile |
|
Closing as it looks like #10594 included aquaproj/aqua-registry#55890. |
Doggo v1.2.0 changed its release asset naming from versioned (
doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless (doggo-{{os}}-{{arch}}.tar.gz) with lowercase OS names and aarch64/i386 arch naming.The vendored aqua registry doesn't yet handle this. The upstream fix has been submitted to aquaproj/aqua-registry (PR #55890) and will flow in on the next vendored registry sync.
In the meantime, this switches to the
github:backend with an explicitasset_patternso doggo v1.2.0+ can be installed immediately. Once the upstream fix is vendored, this can be reverted back toaqua:mr-karan/doggo.This PR was generated with the assistance of an AI coding agent.
Summary by CodeRabbit