fix(aqua): support doggo v1.2.0 asset naming in vendored registry#10600
fix(aqua): support doggo v1.2.0 asset naming in vendored registry#10600jhult wants to merge 1 commit into
Conversation
Doggo v1.2.0 changed its release asset naming from versioned (doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless (doggo-{{os}}-{{arch}}.tar.gz) with lowercase OS names and aarch64/i386 arch names. Added a version override for >= 1.2.0 in the vendored aqua registry to match the new naming while the existing catch-all continues handling older versions.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changesdoggo registry asset mapping
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Will fix upstream. |
Greptile SummaryThis PR adds a
Confidence Score: 3/5Two details in the new override — the tarball The OS/arch naming and constraint ordering look correct, but the vendor/aqua-registry/registry.yml — specifically the Important Files Changed
Reviews (1): Last reviewed commit: "fix(aqua): support doggo v1.2.0 asset na..." | Re-trigger Greptile |
| format: tar.gz | ||
| files: | ||
| - name: doggo | ||
| src: "{{.AssetWithoutExt}}/doggo" |
There was a problem hiding this comment.
src path may not match v1.2.0 tarball layout
{{.AssetWithoutExt}} expands to doggo-linux-x86_64 (or the equivalent per-platform name), so this src expects the binary at doggo-linux-x86_64/doggo inside the archive. Research into the v1.2.0 release suggests the binary may be placed at the archive root (doggo) rather than nested in a named subdirectory — a layout change that would cause aqua to fail to locate the binary on install. Please verify by inspecting the actual tarball structure with tar -tzf doggo-linux-x86_64.tar.gz against the v1.2.0 release assets. If the binary is at the root, src should be just doggo.
| 386: i386 | ||
| checksum: | ||
| type: github_release | ||
| asset: doggo_{{trimV .Version}}_checksums.txt |
There was a problem hiding this comment.
Checksum filename may not exist for v1.2.0
All existing overrides reuse doggo_{{trimV .Version}}_checksums.txt, a versioned filename. If doggo's release workflow also renamed the checksums file when it switched to versionless binary archives (e.g., to checksums.txt or another name), aqua will fail to download the checksum and abort verification. Please confirm the exact checksums asset name from the v1.2.0 GitHub release page before merging.
Doggo v1.2.0 changed its release asset naming from versioned (
doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless (doggo-{{os}}-{{arch}}.tar.gz) with lowercase OS names and aarch64/i386 arch names.Added a version override for >= 1.2.0 in the vendored aqua registry to match the new naming while the existing catch-all continues handling older versions.
Summary by CodeRabbit