Skip to content

fix(aqua): support doggo v1.2.0 asset naming in vendored registry#10600

Closed
jhult wants to merge 1 commit into
jdx:mainfrom
jhult:fix/doggo
Closed

fix(aqua): support doggo v1.2.0 asset naming in vendored registry#10600
jhult wants to merge 1 commit into
jdx:mainfrom
jhult:fix/doggo

Conversation

@jhult

@jhult jhult commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Doggo v1.2.0 changed its release asset naming from versioned (doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless (doggo-{{os}}-{{arch}}.tar.gz) with lowercase OS names and aarch64/i386 arch names.

Added a version override for >= 1.2.0 in the vendored aqua registry to match the new naming while the existing catch-all continues handling older versions.

Summary by CodeRabbit

  • Chores
    • Updated release artifact handling for a packaged download to better match operating systems, architectures, and archive formats.
    • Added checksum-based verification and improved platform-specific packaging, including a Windows zip download option.

Doggo v1.2.0 changed its release asset naming from versioned (doggo_{{version}}_{{OS}}_{{Arch}}.tar.gz) to versionless (doggo-{{os}}-{{arch}}.tar.gz) with lowercase OS names and aarch64/i386 arch names. Added a version override for >= 1.2.0 in the vendored aqua registry to match the new naming while the existing catch-all continues handling older versions.
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a3624c0-57d1-4ff3-83dc-09f185d73f90

📥 Commits

Reviewing files that changed from the base of the PR and between b0de95f and 1d016f7.

📒 Files selected for processing (1)
  • vendor/aqua-registry/registry.yml

📝 Walkthrough

Walkthrough

The doggo entry in vendor/aqua-registry/registry.yml is updated to gate a new release asset configuration behind semver(">= 1.2.0"). The new block specifies a renamed asset template, archive file extraction mapping, architecture string remappings, a GitHub-release checksum source, and a Windows zip format override.

Changes

doggo registry asset mapping

Layer / File(s) Summary
doggo semver-gated asset config
vendor/aqua-registry/registry.yml
Introduces a version_constraint: semver(">= 1.2.0") block replacing the unconditional entry. Sets asset template to doggo-{{.OS}}-{{.Arch}}.{{.Format}}, adds files extraction mapping (name: doggo), remaps amd64/arm64/386 to x86_64/aarch64/i386, attaches a github_release checksum source, and overrides format to zip on Windows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A doggo fetched a new release today,
With semver gates to guide the way,
Arch strings remapped, checksums in tow,
On Windows zipped — all set to go!
🐾 Hops the rabbit, all is fine! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating the vendored Aqua registry for doggo v1.2.0 asset naming.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jhult

jhult commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Will fix upstream.

@jhult jhult closed this Jun 24, 2026
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a semver(">= 1.2.0") version override for the mr-karan/doggo entry in the vendored aqua registry, switching to the new versionless, lowercase-OS asset naming (doggo-{{.OS}}-{{.Arch}}.{{.Format}}) with updated arch replacements (aarch64, i386).

  • The new override is correctly placed before the "true" catch-all and the OS template variable correctly produces lowercase values without needing explicit replacements.
  • Two details warrant confirmation against the actual v1.2.0 release: (1) the src path {{.AssetWithoutExt}}/doggo assumes a subdirectory inside the tarball, which may have changed to a flat layout in v1.2.0; (2) the checksum asset doggo_{{trimV .Version}}_checksums.txt uses the old versioned filename that may no longer match if the checksums file was also renamed.

Confidence Score: 3/5

Two details in the new override — the tarball src path and the checksum filename — may not match the actual v1.2.0 release artifacts and could cause installation to silently fail or abort; these should be confirmed before merging.

The OS/arch naming and constraint ordering look correct, but the src: "{{.AssetWithoutExt}}/doggo" path would fail if the v1.2.0 tarball extracts the binary to the archive root rather than a named subdirectory, and doggo_{{trimV .Version}}_checksums.txt would fail if the checksums file was also renamed when doggo switched to versionless asset names. Both issues affect the single changed entry on its primary install path.

vendor/aqua-registry/registry.yml — specifically the src and checksum.asset fields of the new >= 1.2.0 override.

Important Files Changed

Filename Overview
vendor/aqua-registry/registry.yml Adds a semver(">= 1.2.0") version override for doggo that switches to versionless lowercase asset names; the src path and checksum filename both need verification against the actual v1.2.0 release artifacts.

Reviews (1): Last reviewed commit: "fix(aqua): support doggo v1.2.0 asset na..." | Re-trigger Greptile

format: tar.gz
files:
- name: doggo
src: "{{.AssetWithoutExt}}/doggo"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 src path may not match v1.2.0 tarball layout

{{.AssetWithoutExt}} expands to doggo-linux-x86_64 (or the equivalent per-platform name), so this src expects the binary at doggo-linux-x86_64/doggo inside the archive. Research into the v1.2.0 release suggests the binary may be placed at the archive root (doggo) rather than nested in a named subdirectory — a layout change that would cause aqua to fail to locate the binary on install. Please verify by inspecting the actual tarball structure with tar -tzf doggo-linux-x86_64.tar.gz against the v1.2.0 release assets. If the binary is at the root, src should be just doggo.

386: i386
checksum:
type: github_release
asset: doggo_{{trimV .Version}}_checksums.txt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Checksum filename may not exist for v1.2.0

All existing overrides reuse doggo_{{trimV .Version}}_checksums.txt, a versioned filename. If doggo's release workflow also renamed the checksums file when it switched to versionless binary archives (e.g., to checksums.txt or another name), aqua will fail to download the checksum and abort verification. Please confirm the exact checksums asset name from the v1.2.0 GitHub release page before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant