-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mongodb to 5.0.0 #466
Conversation
@jdesboeufs - please could you take a look at this, Mongo Atlas is updating users to v5 in March so this will become more important |
Note that there's a difference between the database version and the driver version. Mongo driver 3.7+ is compatable with MongoDB v5. https://www.mongodb.com/docs/drivers/node/current/compatibility/ Having said this - I'd also like to see connect-mongo get this update asap so that I can upgrade to the latest version of mongoose/mongodb. |
can you meage this plz |
I've emailed the maintainer and hopefully will get some attention soon. |
@MarkoCen May I ask why the change in the old CHANGELOG? Am I missing something? In general, this PR looks good. Let me take a look and will merge soon. |
I think it was auto formatted by IDE, I can revert those changes |
@MarkoCen Cool. Could you please help revert it and only add your change? |
@mingchuno reverted changes to the old changelog items |
https://www.npmjs.com/package/connect-mongo?activeTab=versions 5.0.0 released to npm |
mongodb
to 5.0.0#465
I considered the changes in this PR as breaking changes since the
MongoClient
typing in mongodb@5 is not compatible with the one in mongodb@4, so the upgrade will break the interface.Other information:
Checklist:
Added test cases
Updated changelog