Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: callback was already called when code throw after set function #440

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

mingchuno
Copy link
Collaborator

fix #437

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Other information:

  • Checklist:

  • Added test cases

  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #440 (0736f49) into master (2a2cd78) will increase coverage by 0.35%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   81.76%   82.12%   +0.35%     
==========================================
  Files           2        2              
  Lines         181      179       -2     
  Branches       42       42              
==========================================
- Hits          148      147       -1     
+ Misses         22       21       -1     
  Partials       11       11              
Impacted Files Coverage Δ
src/lib/MongoStore.ts 81.92% <60.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2cd78...0736f49. Read the comment docs.

@mingchuno mingchuno merged commit 9847304 into master Sep 17, 2021
@mingchuno mingchuno deleted the fix/callback-already-call-error branch September 17, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Callback was already called" bug
2 participants