-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move mongodb to peerDependencies #435
Conversation
In order to allow `connect-mongo` to adapt to internal Typescript changes (that do not break the interface), we can specify `mongodb` as a peer dependency--allowing end users to use any version of mongodb they want as long as it's a minor release of driver version 4.1.x
@rfox12 You |
@mingchuno I finally got around to finishing out this PR. All 23 tests passed for both version 4.1.0 and 4.1.1 versions of the The way you test a peer dependency is to also include the peer version you want to test in your Please take a look, I think this is ready for release? |
Any update when this will be merged? |
@jdesboeufs @mingchuno My organization is happy to be a maintainer of connect-mongo. We rely on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 82.32% 81.76% -0.56%
==========================================
Files 2 2
Lines 181 181
Branches 42 42
==========================================
- Hits 149 148 -1
Misses 22 22
- Partials 10 11 +1
Continue to review full report at Codecov.
|
@rfox12 Well, I am also a random guy out there that are using this repo and found it is unmaintained. So I ask @jdesboeufs if I can pick it up. I will tried to be here more often. Sadly, I don't have the admin access of this repo too. |
In order to allow
connect-mongo
to adapt to internal Typescript changes (that do not break the interface), we can specifymongodb
as a peer dependency--allowing end users to use any version of mongodb they want as long as it's a minor release of driver version 4.1.xShould close issue: #434 (comment) and issue #433 (comment) and #436 (comment)