Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade mongodb depns to V4 #430

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Conversation

mingchuno
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Other information:

  • Checklist:

  • Added test cases

  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #430 (472c003) into master (cceec18) will decrease coverage by 8.26%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   90.58%   82.32%   -8.27%     
==========================================
  Files           3        2       -1     
  Lines         393      181     -212     
  Branches       47       42       -5     
==========================================
- Hits          356      149     -207     
- Misses         21       22       +1     
+ Partials       16       10       -6     
Impacted Files Coverage Δ
src/lib/MongoStore.ts 82.12% <83.33%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cceec18...472c003. Read the comment docs.

@mingchuno mingchuno force-pushed the feat/upgrade-mongodb-depns branch from f44cc21 to 472c003 Compare August 17, 2021 10:57
@mingchuno mingchuno merged commit fa8826d into master Aug 17, 2021
@mingchuno mingchuno deleted the feat/upgrade-mongodb-depns branch August 17, 2021 10:59
Copy link
Contributor

@guyellis guyellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [10.x, 12.x, 14.x, 15.x]
node-version: [12.x, 14.x, 15.x, 16.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

"statements": 80,
"exclude": ["src/test"]
"exclude": ["src/test", "src/lib/MongoStore.spec.ts"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this accept wildcard syntax such that you could put "*.spec.ts"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants