Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move writeConcern option away from top-level to remove deprecation warning #422 #424

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

mingchuno
Copy link
Collaborator

@mingchuno mingchuno commented Jun 15, 2021

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Other information:

  • Checklist:

  • Added test cases

  • Updated changelog

@mingchuno
Copy link
Collaborator Author

fix #422

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #424 (c1a537c) into master (9c1d0b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files           3        3           
  Lines         393      393           
  Branches       47       47           
=======================================
  Hits          356      356           
  Misses         21       21           
  Partials       16       16           
Impacted Files Coverage Δ
src/lib/MongoStore.ts 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1d0b5...c1a537c. Read the comment docs.

@mingchuno mingchuno force-pushed the fix/422-deprecated-top-level-write-concern branch from 4da6aa7 to c1a537c Compare June 15, 2021 04:19
@mingchuno mingchuno merged commit cceec18 into master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants