Check pre release ff not ga #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyclam
approved these changes
Sep 26, 2023
sunnycarter
merged commit f3584bb
into
pre-release-add-aosm-extension
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert accidental pre-release merge of #71 but change it to check for the FF you need for pre-release. https://eng.ms/docs/strategic-missions-and-technologies/strategic-missions-and-technologies-organization/azure-for-operators/aiops/aiops-orchestration/aosm-product-docs/shared_infrastructure/ansm_onboarding
Anand told me that the MsiForResourceEnabled one isn't required any more, so I am not checking for that one.
The GA release deliberately doesn't have the FF names listed in the README.md as Peter told me they are somehow "hidden" FF, and the customer shouldn't know their names, just to follow the onboarding docs. The Pre-release ones I think are useful though.
I've tested this on our UK subscription.