ADO-880627: Use docker-less ACR login

[wbradley94]

For running in environments without docker, such as CI pipelines. This affects uploading Helm charts for CNFs - the ACR login now fetches an access token, which is used to login to the Helm registry and upload the chart.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aosm nfd publish

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Fix details

Fix for https://dev.azure.com/msazuredev/AzureForOperators/_workitems/edit/880627/. OneBranch pipelines run in an environment without docker. When running az aosm nfd publish --definition-type cnf, docker is currently used to login to the ACR backing the publisher artifact store.

The Azure CLI supports docker-less login by way of an access token - see https://learn.microsoft.com/en-us/azure/container-registry/container-registry-authentication?tabs=azure-cli.

Testing

1. I tested that this variant of az acr login works when run in a OneBranch pipeline. See this commit: https://dev.azure.com/msazuredev/AzureForOperators/_git/afosas-aosm-nfd/commit/138f796d600c1eeaee28105b6ceb6c27cdaf7afc?refName=refs%2Fheads%2Fwb2%2Fstory-737052-ci-to-publish-nfd & successful pipeline stage: https://dev.azure.com/msazuredev/AzureForOperators/_build/results?buildId=1089950&view=logs&j=45688f8f-8b77-5d43-14e3-e592d7b4138f&t=3495c423-bdbb-557b-d256-591edca2e36d. I also tested the script locally.
2. I locally re-enabled the integration tests for VNFs & CNFs and confirmed they worked. The CNF integration test failed when trying to publish the NSD - I didn't determine why, but I claim it is unrelated to my change. The NFD publish command was successful.
3. I manually ran the az aosm nfd publish --definition-type cnf command for a SAS NFD and confirmed the Helm chart was uploaded successfully.

[patrykkulik-microsoft]

Looks good to me

[sunnycarter]

Thanks for doing this Will, very helpful. :) FYI some README changes were required alongside this change, I'll make those now but FYI for future PRs.

[wbradley94]

Thanks for doing this Will, very helpful. :) FYI some README changes were required alongside this change, I'll make those now but FYI for future PRs.

Thanks very much Sunny, I did make a note of this when I started development but completely forgot!