Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed configuration type from secret to open #162

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented Mar 22, 2024


  • changed configuration type from secret to open;
  • updated changelog
    This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Cyclam
Copy link
Collaborator

Cyclam commented Mar 22, 2024

LGTM. Just confirm, the request here was from Art and Pete, who are happy that it's OK to have these config types open.

@Cyclam Cyclam assigned Cyclam and unassigned Cyclam Mar 22, 2024
@Cyclam Cyclam requested review from Cyclam and removed request for sunnycarter March 22, 2024 15:21
@jordlay jordlay merged commit 3e5977c into main Mar 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants