Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool in schema bug #160

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Fix bool in schema bug #160

merged 3 commits into from
Mar 19, 2024

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented Mar 15, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Cyclam
Copy link
Collaborator

Cyclam commented Mar 19, 2024

I've reverted the change that separated the processing of oneOf and anyOf errors. I think the motivation was to provide the user with a more tailored error message, but in this case, I think the existing message was still pretty clear, and it gave the user the chance to clear up multiple issues with their file, rather than having to run again to get the further advice.

Anyway, it's not part of the bug fix, so arguably should be in a different PR anyway :-)

@Cyclam Cyclam merged commit 54b02ea into main Mar 19, 2024
@Cyclam Cyclam deleted the jl/bug-additional-params branch March 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants